Skip to content

Removed references to private registry #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 12, 2025

Conversation

fabriziofiorucci
Copy link
Contributor

Proposed changes

Removed references to private registry as my-docker-registry:port isn't mentioned in the sample values.yaml file

Checklist

Before merging a pull request, run through this checklist and mark each as complete.

  • I have read the contributing guidelines
  • I have signed the F5 Contributor License Agreement (CLA)
  • I have rebased my branch onto main
  • I have ensured my PR is targeting the main branch and pulling from my branch from my own fork
  • I have ensured that the commit messages adhere to Conventional Commits
  • I have ensured that documentation content adheres to the style guide
  • If the change involves potentially sensitive changes1, I have assessed the possible impact
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • I have ensured that existing tests pass after adding my changes
  • If applicable, I have updated README.md and CHANGELOG.md

Footnotes

  1. Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer to our style guide for guidance about placeholder content.

@fabriziofiorucci fabriziofiorucci requested a review from a team as a code owner March 11, 2025 14:39
@JTorreG JTorreG added the product/nim NGINX Instance Manager label Mar 11, 2025
@JTorreG JTorreG merged commit a706afa into nginx:main Mar 12, 2025
3 of 4 checks passed
@fabriziofiorucci fabriziofiorucci deleted the ff20250311 branch March 12, 2025 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product/nim NGINX Instance Manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants