Skip to content

fix: update helm doc with NIM 2.18 and fix broken links #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 6, 2025

Conversation

balakoteswar
Copy link
Contributor

Proposed changes

This PR contains helm deployment documentation support for older versions of NIM releases. Also fixed few broken links.

Problem: Currently there is no support for deploying the NIM using helm for NIM version v2.18.0 or lower

Solution: Updated the docs to support deploying the NIM using helm for NIM version v2.18.0 or lower

Testing: Performed local testing.

Closes # N/A

Checklist

Before merging a pull request, run through this checklist and mark each as complete.

  • I have read the contributing guidelines
  • I have signed the F5 Contributor License Agreement (CLA)
  • I have rebased my branch onto main
  • I have ensured my PR is targeting the main branch and pulling from my branch from my own fork
  • I have ensured that the commit messages adhere to Conventional Commits
  • I have ensured that documentation content adheres to the style guide
  • If the change involves potentially sensitive changes1, I have assessed the possible impact
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • I have ensured that existing tests pass after adding my changes
  • If applicable, I have updated README.md and CHANGELOG.md

Footnotes

  1. Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer to our style guide for guidance about placeholder content.

@balakoteswar balakoteswar requested a review from a team as a code owner March 5, 2025 19:26
Copy link
Contributor

@mjang mjang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with @travisamartin 's suggestions

mjang and others added 3 commits March 5, 2025 12:18
Co-authored-by: Travis Martin <33876974+travisamartin@users.noreply.github.com>
Co-authored-by: Travis Martin <33876974+travisamartin@users.noreply.github.com>
@JTorreG JTorreG added the product/nim NGINX Instance Manager label Mar 6, 2025
@JTorreG JTorreG merged commit 6a2c2be into nginx:main Mar 6, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product/nim NGINX Instance Manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants