Skip to content

Update product titles and articles in getting-started.md #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 5, 2025

Conversation

4acf
Copy link
Contributor

@4acf 4acf commented Mar 5, 2025

Proposed changes

Problem: Phrases with the article "the" before a product name in content/nginx-one/getting-started.md don't conform to style updates.

Solution: Changed all instances of "NGINX One console" to "NGINX One Console" and removed the article "the" in front of other relevant instances such as "the NGINX One Agent" or "the F5 Distributed Console". I made sure to leave the article "the" for some cases like "the NGINX One dashboard" as it isn't its own product.

Testing: N/A

If this PR addresses an issue on GitHub, ensure that you link to it here:

#228 (only addresses a small portion of the issue)

Checklist

Before merging a pull request, run through this checklist and mark each as complete.

  • I have read the contributing guidelines
  • I have signed the F5 Contributor License Agreement (CLA)
  • I have rebased my branch onto main
  • I have ensured my PR is targeting the main branch and pulling from my branch from my own fork
  • I have ensured that the commit messages adhere to Conventional Commits
  • I have ensured that documentation content adheres to the style guide
  • If the change involves potentially sensitive changes1, I have assessed the possible impact
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • I have ensured that existing tests pass after adding my changes
  • If applicable, I have updated README.md and CHANGELOG.md

Footnotes

  1. Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer to our style guide for guidance about placeholder content.

@4acf 4acf requested a review from a team as a code owner March 5, 2025 07:57
@JTorreG JTorreG added the product/nginx-one NGINX One Console label Mar 5, 2025
Copy link
Contributor

@mjang mjang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for another excellent contribution!

@mjang mjang merged commit b7c1913 into nginx:main Mar 5, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants