Skip to content

Add missing NGINXaaS certificate error descriptions and resolutions #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

dylan-way
Copy link
Contributor

@dylan-way dylan-way commented Feb 21, 2025

Proposed changes

Problem: NGINXaaS returns various certificate errors to the user to assist them in fixing their deployments. Some of these user-facing errors point to this documentation but there isn't a corresponding certificate errors entry.

Solution: Adds the following error codes to the NGINXaaS certificate errors list:

  • NoCertificateContent
  • MissingContentType
  • UnrecognizedContentType
  • PKCS12ParseFailure
  • PEMParseFailure

Closes Failed Customer Deployment Creation in swedencentral

Checklist

Before merging a pull request, run through this checklist and mark each as complete.

  • I have read the contributing guidelines
  • I have signed the F5 Contributor License Agreement (CLA)
  • I have rebased my branch onto main
  • I have ensured my PR is targeting the main branch and pulling from my branch from my own fork
  • I have ensured that the commit messages adhere to Conventional Commits
  • I have ensured that documentation content adheres to the style guide
  • If the change involves potentially sensitive changes1, I have assessed the possible impact
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • I have ensured that existing tests pass after adding my changes
  • If applicable, I have updated README.md and CHANGELOG.md

Footnotes

  1. Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer to our style guide for guidance about placeholder content.

@dylan-way dylan-way requested a review from a team as a code owner February 21, 2025 15:47
Copy link

github-actions bot commented Feb 21, 2025

✅ All required contributors have signed the F5 CLA for this PR. Thank you!
Posted by the CLA Assistant Lite bot.

@dylan-way
Copy link
Contributor Author

I have hereby read the F5 CLA and agree to its terms

Adds the following error codes:
- NoCertificateContent
- MissingContentType
- UnrecognizedContentType
- PKCS12ParseFailure
- PEMParseFailure
Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JTorreG JTorreG merged commit 422733b into nginx:main Feb 21, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants