fix: updated the k8s documentation for NIM v2.19.0 release #208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JTorreG
reviewed
Feb 19, 2025
JTorreG
reviewed
Feb 19, 2025
JTorreG
reviewed
Feb 19, 2025
balakoteswar
commented
Feb 19, 2025
| @@ -23,4 +23,4 @@ You can access the NGINX Instance Manager web interface using the external IP ad | |||
|
|
|||
| For example, `https://10.108.57.167/ui`. | |||
|
|
|||
| This IP address might not be reachable, depending on how the Kubernetes cluster networking was configured. If so, the `apigw` service type can be changed to a more suitable option, such as `LoadBalancer`, by changing the [Configurable Helm Setting]({{< relref "/nim/deploy/kubernetes/helm-config-settings.md" >}}) value for `nms-hybrid.apigw.service.type` . | |||
| This IP address might not be reachable, depending on how the Kubernetes cluster networking was configured. If so, the `apigw` service type can be changed to a more suitable option, such as `LoadBalancer`, by changing the [Configurable Helm Setting]({{< relref "/nim/deploy/kubernetes/helm-config-settings.md" >}}) value for `apigw.service.type`. | |||
There was a problem hiding this comment.
I'm not able to identify the suggested change. Please help me here.
JTorreG
approved these changes
Feb 19, 2025
| @@ -23,4 +23,4 @@ You can access the NGINX Instance Manager web interface using the external IP ad | |||
|
|
|||
| For example, `https://10.108.57.167/ui`. | |||
|
|
|||
| This IP address might not be reachable, depending on how the Kubernetes cluster networking was configured. If so, the `apigw` service type can be changed to a more suitable option, such as `LoadBalancer`, by changing the [Configurable Helm Setting]({{< relref "/nim/deploy/kubernetes/helm-config-settings.md" >}}) value for `nms-hybrid.apigw.service.type` . | |||
| This IP address might not be reachable, depending on how the Kubernetes cluster networking was configured. If so, the `apigw` service type can be changed to a more suitable option, such as `LoadBalancer`, by changing the [Configurable Helm Setting]({{< relref "/nim/deploy/kubernetes/helm-config-settings.md" >}}) value for `apigw.service.type`. | |||
There was a problem hiding this comment.
no change. github ui hiccup
mjang
approved these changes
Feb 20, 2025
There was a problem hiding this comment.
I'm approving with the comments as requested. I've made my own interpretations. If I've made mistakes, @balakoteswar , you're welcome to submit another PR.
travisamartin
pushed a commit
that referenced
this pull request
Jun 16, 2025
travisamartin
added a commit
that referenced
this pull request
Jun 16, 2025
* docs: add support for lightweight mode and clarify ClickHouse configuration * build(deps): bump github/codeql-action from 3.28.15 to 3.28.16 (#459) Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.28.15 to 3.28.16. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@45775bd...28deaed) --- updated-dependencies: - dependency-name: github/codeql-action dependency-version: 3.28.16 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Alan Dooley <a.dooley@f5.com> Co-authored-by: Mike Jang <3287976+mjang@users.noreply.github.com> * fix: Address typo, update metadata for Add a Staged Configuration topic (#549) This commit fixes a typo in the main body text of the documentation, and also updates the Hugo frontmatter to new parameter names and values. * Updated example description for uwsgi and Django. (#552) Co-authored-by: Alan Dooley <a.dooley@f5.com> * Fixed URL to dynamic modules for Wildfly deployment guide. (#548) * Fixed URL to dynamic modules for Wildfly deployment guide. * Apply suggestions from code review Co-authored-by: Alan Dooley <github@adubhlaoi.ch> --------- Co-authored-by: Alan Dooley <github@adubhlaoi.ch> Co-authored-by: Alan Dooley <a.dooley@f5.com> * Removed random symbols introduced in #512 (#546) * Add a new trigger to build push workflow (#554) feat: Add a new trigger to build push workflow * added flag to use to skip installing clickhouse * updated install guides with latest script changes * edits to system config titles * added NGINX Agent version requirement for lightweight NIM * added step for adding NGINX signing key for manual install * updated clickhouse version variable * added variable for lightweight NIM NGINX Agent requirement * reworded lightweight option to lightweight mode * added steps for adding instances * added steps for setting up metrics reporting * edits * added lightweight mode content to docker compose doc * Apply suggestions from code review Co-authored-by: Jon Torre <78599298+JTorreG@users.noreply.github.com> * edits to helm deploy for lightweight mode * Update license_usage_offline.sh * feat: Updated nim install-script (#202) * Update install-nim-bundle.sh * fix: Update install-nim-bundle.sh * removed cruft from docker-compose-lightweight.yaml * edits to docker compose comments * Update license_usage_offline.sh * feat: Updated nim install-script (#202) * Update install-nim-bundle.sh * fix: Update install-nim-bundle.sh * feat: Update the value of ssl_protocols. (#672) * NGF: Update release version to v2.0.1 (#671) Update doc version for NGF release 2.0.1 * NGF: replace static-mode with controller (#669) Problem: The static-mode command has been renamed. Solution: Update to `controller`. * Fix missing quote (#676) A quotation was missing that was not caught by the original PR pipeline. * updates to helm config settings with new chart name * docs: add 2.20 RNs * Update install-nim-manual.md * Update install.md * docs: add 2.20 KIs * incremented helm chart version table * nim 2.20 ki update steps * Update install-nim-bundle.sh (#208) --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Alan Dooley <a.dooley@f5.com> Co-authored-by: Mike Jang <3287976+mjang@users.noreply.github.com> Co-authored-by: yar <y82@users.noreply.github.com> Co-authored-by: Alan Dooley <github@adubhlaoi.ch> Co-authored-by: Lam <150060045+lamATnginx@users.noreply.github.com> Co-authored-by: Jon Torre <78599298+JTorreG@users.noreply.github.com> Co-authored-by: Chetan Jain <46200286+Chetan-99@users.noreply.github.com> Co-authored-by: salonichf5 <146118978+salonichf5@users.noreply.github.com> Co-authored-by: Saylor Berman <s.berman@f5.com> Co-authored-by: Jon Cahill-Torre <j.cahilltorre@f5.com> Co-authored-by: Micheal Kingston <44472403+mkingst@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Testing: Performed local testing, everything is working as expected.
If this PR addresses an issue on GitHub, ensure that you link to it here:
Closes #ISSUE
Checklist
Before merging a pull request, run through this checklist and mark each as complete.
README.mdandCHANGELOG.mdFootnotes
Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer to our style guide for guidance about placeholder content. ↩