Skip to content

Delete content/nim/deploy/docker/deploy-nginx-instance-manager-docker.md #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 25, 2025

Conversation

mkingst
Copy link
Contributor

@mkingst mkingst commented Feb 12, 2025

Proposed changes

Removed the Singe Docker container docs. We stopped maintaining this image as it was for demo's only. Customers should use Docker Compose going forward. We make this clear in the docs that this is not recommended.

@mkingst mkingst requested a review from a team as a code owner February 12, 2025 09:40
@ADubhlaoich
Copy link
Contributor

@mkingst Change LGTM but deleting this file outright has caused some broken Hugo references.

The errors show what text needs to be updated/removed.

@ADubhlaoich
Copy link
Contributor

We discussed this PR during a DocOps meeting: I'm taking initiative to push directly to the PR to address the issues myself.

Copy link

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/docs/191/

@ADubhlaoich ADubhlaoich enabled auto-merge (squash) February 25, 2025 17:10
Copy link
Contributor

@mjang mjang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You caught the links, thanks.

@ADubhlaoich ADubhlaoich merged commit a97af20 into main Feb 25, 2025
8 checks passed
@ADubhlaoich ADubhlaoich deleted the mkingst-remove-single-docker-container branch February 25, 2025 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants