Skip to content

fix: redoc menu content is now scrollable #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 3, 2025
Merged

Conversation

lamATnginx
Copy link
Contributor

Proposed changes

  • Allow Redoc menu to be scrollable.

GitHub Issue:
Closes https://github.com/nginxinc/docs-platform/issues/281

Checklist

Before merging a pull request, run through this checklist and mark each as complete.

  • I have read the contributing guidelines
  • I have signed the F5 Contributor License Agreement (CLA)
  • I have ensured that documentation content adheres to the style guide
  • If the change involves potentially sensitive changes, I have assessed the possible impact
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md and CHANGELOG.md)
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation.

Please refer to our style guide for guidance about placeholder content.

@lamATnginx lamATnginx requested a review from a team as a code owner February 3, 2025 19:21
Copy link

github-actions bot commented Feb 3, 2025

✅ All required contributors have signed the F5 CLA for this PR. Thank you!
Posted by the CLA Assistant Lite bot.

@lamATnginx
Copy link
Contributor Author

I have hereby read the F5 CLA and agree to its terms

@lamATnginx lamATnginx self-assigned this Feb 3, 2025
@lamATnginx lamATnginx added the bug Something isn't working label Feb 3, 2025
Copy link

github-actions bot commented Feb 3, 2025

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/docs/163/

@lamATnginx lamATnginx enabled auto-merge (squash) February 3, 2025 19:27
Copy link
Contributor

@mjang mjang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ability to scroll, with this PR, is confirmed. Thanks!

@lamATnginx lamATnginx merged commit 54f99af into main Feb 3, 2025
4 checks passed
@lamATnginx lamATnginx deleted the fix/redoc-scroll branch February 3, 2025 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants