-
Notifications
You must be signed in to change notification settings - Fork 32
Allow installation of current 'structlog' major version 21.x #75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
glennmatthews
merged 17 commits into
networktocode:main
from
grelleum:gpm-relax-structlog-required-version
Dec 13, 2021
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
72e3684
Pinned pylint minor version to 2.6 to ensure test completion.
grelleum 9c826fb
Allow installation of current structlog version 21.x.
grelleum c34340d
Updated to allow testing of latest structlog.
grelleum 58670f7
Added checks to see if the 'format_exc_info' processor is required.
grelleum f853356
Selective pull for merge fix.
grelleum 3c8149b
Merge branch 'main' of github.com:networktocode/diffsync into merge_fix
grelleum 213d8e1
Allow current structlog version.
grelleum ca783e4
Formatted with black 21.11b1.
grelleum 5b0eebb
Pylint: disable import-outside-toplevel, import-error within import t…
grelleum 9465585
Restored poetry.lock from branch main.
grelleum 32fb865
Modifed docstring to conform to pydocstyle.
grelleum 157bb8a
Replaced try:import:except with importlib.util.find_spec.
grelleum 0757c76
Use 'version.parse' to determine structlog.__version__.
grelleum 1340397
Fixed import order.
grelleum 844fc83
Fixed extraneous line after docstring.
grelleum 54f749d
Added missing line: 'processors=processors,'.
grelleum e561c2c
Changed the import from importlib.utils to work on Python 3.9.
grelleum File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we need a
processors=processors,
line added here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, it got lost somewhere in the experimentation phase. Added this back in.