Skip to content

Update project to support Python 3.6 & 3.9 and update travis to use stages #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 26 commits into from
Dec 8, 2020

Conversation

dgarros
Copy link
Contributor

@dgarros dgarros commented Dec 5, 2020

This PR update pyproject.toml and the dependencies to support Python 3.6 and python 3.9.
No changes in the code were required.

Also in the process, I did some cleanup

  • Updated some files to align with the latest dev-standard
  • Removed unused deps like request_mocks and ipython
  • Refactor the travis file with stages, leveraging the native python version in travis.

@glennmatthews
Copy link
Collaborator

Looks like something isn't quite right with the pyproject.toml changes versus the poetry.lock changes:

Warning: The lock file is not up to date with the latest changes in pyproject.toml. You may be getting outdated dependencies. Run update to update them.

@dgarros dgarros requested a review from glennmatthews December 8, 2020 12:02
glennmatthews
glennmatthews previously approved these changes Dec 8, 2020
Copy link
Collaborator

@glennmatthews glennmatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more mypy fix needed, otherwise looks good to me. Thanks!

@glennmatthews glennmatthews merged commit f91cd6d into master Dec 8, 2020
@glennmatthews glennmatthews deleted the dga-std-update branch December 8, 2020 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants