feat: add support for scheduled functions to Go client #368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eduardoboucas
added
the
type: feature
|
✔️ Deploy Preview for open-api ready! 🔨 Explore the source changes: f043261 🔍 Inspect the deploy log: https://app.netlify.com/sites/open-api/deploys/61d4190110c54600083c4d17 😎 Browse the preview: https://deploy-preview-368--open-api.netlify.app |
eduardoboucas
commented
Jan 4, 2022
| @@ -91,7 +91,7 @@ type DeployOptions struct { | |||
|
|
|||
| files *deployFiles | |||
| functions *deployFiles | |||
| functionSchedules []models.FunctionSchedule | |||
| functionSchedules []*models.FunctionSchedule | |||
There was a problem hiding this comment.
The change to pointers here is just so that it matches the FunctionSchedules type from DeployFiles without doing any conversion.
eduardoboucas
commented
Jan 4, 2022
| @@ -238,10 +238,15 @@ func (n *Netlify) DoDeploy(ctx context.Context, options *DeployOptions, deploy * | |||
| } | |||
| } | |||
|
|
|||
| if len(schedules) > 0 { | |||
| deployFiles.FunctionSchedules = schedules | |||
There was a problem hiding this comment.
This is where we pass the schedules to the deploy options.
eduardoboucas
commented
Jan 4, 2022
| @@ -580,7 +585,7 @@ func walk(dir string, observer DeployObserver, useLargeMedia, ignoreInstallDirs | |||
| return files, err | |||
| } | |||
|
|
|||
| func bundle(functionDir string, observer DeployObserver) (*deployFiles, []models.FunctionSchedule, error) { | |||
| func bundle(ctx context.Context, functionDir string, observer DeployObserver) (*deployFiles, []*models.FunctionSchedule, error) { | |||
There was a problem hiding this comment.
bundle and bundleFromManifest are now receiving the context so that they can acquire a logger and print a debug message.
mrdg
approved these changes
Jan 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FunctionSchedulesproperty to the deploy options when function schedules are detectedscheduled_functionslog field to an existing log message, showing the number of scheduled functions detected for the deploy