Skip to content
This repository was archived by the owner on May 10, 2021. It is now read-only.

Fix: Add support for res.redirect in API routes #93

Merged
merged 1 commit into from
Nov 18, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions cypress/fixtures/pages/api/redirect.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
export default async function preview(req, res) {
const { query } = req;
const { to } = query;

res.redirect(`/shows/${to}`);
}
8 changes: 8 additions & 0 deletions cypress/integration/default_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -526,6 +526,14 @@ describe("API endpoint", () => {
);
});
});

it("redirects with res.redirect", () => {
cy.visit("/api/redirect?to=999");

cy.url().should("include", "/shows/999");
cy.get("h1").should("contain", "Show #999");
cy.get("p").should("contain", "Flash Gordon");
});
});

describe("Preview Mode", () => {
Expand Down
4 changes: 4 additions & 0 deletions lib/templates/createResponseObject.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,10 @@ const createResponseObject = ({ onResEnd }) => {
res.writeHead = (status, headers) => {
response.statusCode = status;
if (headers) res.headers = Object.assign(res.headers, headers);

// Return res object to allow for chaining
// Fixes: https://github.com/netlify/next-on-netlify/pull/74
return res;
};
res.write = (chunk) => {
if (!response.body) {
Expand Down