Add settings info to the message shown as each run starts #568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy Preview for plugin-lighthouse processing.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a function to embellish the "Running Lighthouse on example/" message using supplied settings. This helps verify settings have been picked up correctly without needing to wait and review the final report output. I wonder if it's too wordy – maybe we look again if we expose more settings in future.
Screenshots taken locally. The changes affect the output of a single console.log so should be identical in build logs
Examples
Single run, no custom settings
Multi-page run, no custom settings
With a single custom setting
With multiple custom settings
