Skip to content

Add some additional specs and set up jest coverage #542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 26, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions jest.config.cjs
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,5 @@ module.exports = {
testMatch: ['**/__tests__/**/*.+(ts|js)', '**/?(*.)+(spec|test).+(ts|js)'],
setupFiles: ['<rootDir>/test/setup.js'],
transform: {},
collectCoverageFrom: ['**/*.js'],
};
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"local": "node -e 'import(\"./src/index.js\").then(index => index.onPostBuild());'",
"lint": "eslint 'src/**/*.js'",
"format": "prettier --write 'src/**/*.js'",
"test": "node --experimental-vm-modules node_modules/jest/bin/jest.js",
"test": "node --experimental-vm-modules node_modules/jest/bin/jest.js --collect-coverage",
"format:ci": "prettier --check 'src/**/*.js'"
},
"keywords": [
Expand Down
17 changes: 17 additions & 0 deletions src/lib/get-serve-path/get-serve-path.test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
import getServePath from '.';

describe('getServePath', () => {
it('returns undefined for dir thats not a string', () => {
expect(getServePath(2)).toEqual({ serveDir: undefined });
});

it('returns undefined for subdir thats not a string', () => {
expect(getServePath(2, 2)).toEqual({ serveDir: undefined });
});

it('returns joined path for serveDir', () => {
expect(getServePath('example', 'path')).toEqual({
serveDir: 'example/path',
});
});
});
64 changes: 64 additions & 0 deletions src/lib/get-server/get-server.test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,64 @@
jest.unstable_mockModule('chalk', () => {
return {
default: {
magenta: (m) => m,
},
};
});

const mockedExpress = () => ({
use: jest.fn(),
listen: jest.fn(),
});
const mockStatic = jest.fn();
Object.defineProperty(mockedExpress, 'static', { value: mockStatic });

jest.unstable_mockModule('express', () => {
return {
default: mockedExpress,
};
});
const getServer = (await import('.')).default;

describe('getServer', () => {
beforeEach(() => {
jest.clearAllMocks();
});

it('returns a mock server if audit URL is defined', () => {
const mockListen = jest.fn();
console.log = jest.fn();

const { server } = getServer({ auditUrl: '/' });
expect(server.listen).toBeDefined();
server.listen(mockListen);
expect(mockListen).toHaveBeenCalled();
expect(console.log.mock.calls[0][0]).toEqual('Scanning url /');

expect(server.close).toBeDefined();
expect(server.close()).toBeUndefined();
expect(server.url).toEqual('/');
});

it('throws an error if no audit URL and no serveDir', () => {
expect(() => getServer({})).toThrow('Empty publish dir');
});

it('returns an express server if no audit URL and a serveDir', () => {
const { server } = getServer({ serveDir: 'dir' });
expect(mockStatic).toHaveBeenCalled();

// Check we log when we start serving directory
server.listen(jest.fn());
expect(console.log.mock.calls[0][0]).toEqual(
'Serving and scanning site from directory dir',
);

expect(server.url).toEqual('http://localhost:5100');

// Check close method closes the given instance
const close = jest.fn();
server.close({ close });
expect(close).toHaveBeenCalled();
});
});