Skip to content

fix(deps): update dependency puppeteer to v19 #499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Oct 17, 2022

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
puppeteer (source) ^18.0.0 -> ^19.0.0 age adoption passing confidence

Configuration

📅 Schedule: Branch creation - "before 9am on Friday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot requested a review from a team October 17, 2022 01:17
@netlify
Copy link

netlify bot commented Oct 17, 2022

👷 Deploy Preview for plugin-lighthouse processing.

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/plugin-lighthouse/deploys/635a9954ee24b43e10a511e4

@aitchiss aitchiss self-requested a review October 27, 2022 10:25
@aitchiss aitchiss requested a review from a team October 27, 2022 14:27
@aitchiss aitchiss removed request for a team October 27, 2022 14:30
@aitchiss aitchiss closed this Oct 27, 2022
@aitchiss aitchiss reopened this Oct 27, 2022
@aitchiss
Copy link
Contributor

@jackbrewer I made a small change to this PR as when I tested locally/pointing at this branch, lighthouse reports weren't generating (with an error from createBrowserFetcher).

With the added empty object argument, things are working locally again. The deploy preview here has failed but clicking "clear cache and retry with latest branch commit" results in the deploy working fine... but that doesn't unblock the checks on this PR 🙃

Not sure how concerned I need to be that I had to click the "clear cache and retry" option - have you seen this happen before?

@aitchiss
Copy link
Contributor

The original problem with this upgrade was that createBrowserFetcher now requires an object to be passed as an arg, as puppeteer attempts to spread it within the function. I've tried a fix for that here, but I'm encountering some weird CI issues as above.

Reflecting on things though, I think we can hit pause on this one for a moment. Puppeteer is deprecating createBrowserFetcher, in favour of using BrowserFetcher directly. Instead of investing time debugging this build, let's instead create an issue to upgrade manually, and migrate to using BrowserFetcher.

@aitchiss aitchiss closed this Oct 31, 2022
@renovate
Copy link
Contributor Author

renovate bot commented Oct 31, 2022

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update. You will not get PRs for any future 19.x releases. But if you manually upgrade to 19.x then Renovate will re-enable minor and patch updates automatically.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.

@renovate renovate bot deleted the renovate/puppeteer-19.x branch October 31, 2022 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant