Skip to content

fix: netlifyConfig readonly #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 26, 2021
Merged

fix: netlifyConfig readonly #21

merged 1 commit into from
May 26, 2021

Conversation

ehmicky
Copy link
Contributor

@ehmicky ehmicky commented May 26, 2021

As we are currently making some properties of netlifyConfig mutable, we are also making the other properties explicitly readonly, i.e. mutating them directly will fail.
This PR fixes this in this plugin, without changing the behavior otherwise.

@ehmicky ehmicky requested a review from mraerino May 26, 2021 13:21
@ehmicky ehmicky self-assigned this May 26, 2021
@ehmicky ehmicky merged commit 73c0959 into main May 26, 2021
@ehmicky ehmicky deleted the fix/config-readonly branch May 26, 2021 13:56
@ehmicky
Copy link
Contributor Author

ehmicky commented May 27, 2021

@mraerino Should we make a new npm release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants