feat: support disabling of Netlify function generation #240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for netlify-plugin-gatsby-demo canceled. 🔨 Explore the source changes: 3afe68f 🔍 Inspect the deploy log: https://app.netlify.com/sites/netlify-plugin-gatsby-demo/deploys/61f14851c28deb00081e36af |
tiffafoo
reviewed
Jan 26, 2022
tiffafoo
reviewed
Jan 26, 2022
…gin-gatsby into mk/disable-functions
tiffafoo
previously approved these changes
Jan 26, 2022
tiffafoo
approved these changes
Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we have no way of knowing at build time whether there are any DSG or SSR pages, or Gatsby Functions. For this reason we always have to generate the handler functions. This PR adds the ability to disable these both manually by setting an env var, and programatically by creating a file in the cache dir. The latter feature is to allow
gatsby-plugin-netlifyto disable it automatically (PR to follow).To test:
NETLIFY_SKIP_GATSBY_FUNCTIONS=1 ntl buildand observe the message in theonBuildhandler.gatsby build && touch .cache/.nf-skip-gatsby-functionsthen runntl buildand observe a different message.Fixes #166. Fixes #219. Fixes #214