Skip to content

chore: update readme for GA #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 26, 2022
Merged

chore: update readme for GA #239

merged 3 commits into from
Jan 26, 2022

Conversation

ascorbic
Copy link
Contributor

@ascorbic ascorbic commented Jan 25, 2022

This PR updates the readme to reflect the changes for version 2 GA.

Rendered version

tiffafoo
tiffafoo previously approved these changes Jan 26, 2022
Copy link
Contributor

@KyleBlankRollins KyleBlankRollins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Nice write up, @ascorbic. I have some suggestions, but nothing blocking. Mostly minor grammar/reading optimization things.

You're able to
[remove the plugin](https://docs.netlify.com/configure-builds/build-plugins/#remove-a-plugin)
at any time by visiting the **Plugins** tab for your site in the Netlify UI. -->
### Installing the Netlify build plugin
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[sand] This header uses "Installing" while the following header (line 43) uses "Install". They should use the same verb form. I advocate using "installing" for both, but you could make an argument either way.

Co-authored-by: Kyle Rollins <kyleblankrollins@gmail.com>
@ascorbic ascorbic dismissed stale reviews from KyleBlankRollins and tiffafoo via 6d345af January 26, 2022 17:06
@netlify
Copy link

netlify bot commented Jan 26, 2022

✔️ Deploy Preview for netlify-plugin-gatsby-demo ready!

🔨 Explore the source changes: 042bcf2

🔍 Inspect the deploy log: https://app.netlify.com/sites/netlify-plugin-gatsby-demo/deploys/61f18191e06afe000815ab28

😎 Browse the preview: https://deploy-preview-239--netlify-plugin-gatsby-demo.netlify.app/blog

@ascorbic
Copy link
Contributor Author

@KyleBlankRollins All great suggestions, thanks!

@kodiakhq kodiakhq bot merged commit b2b1dee into main Jan 26, 2022
@kodiakhq kodiakhq bot deleted the mk/ga-readme branch January 26, 2022 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants