Deployments should fail when there are build errors

[ericselin]

Current behavior

When netlify-lambda build has an error (due to an error from webpack), we end up with a deployment on Netlify with no functions (functions dir empty due to webpack build failing).

Expected behavior

The whole deploy should fail.

Reproduction

Create a simple function that doesn't build (e.g. syntax error or whatever) and deploy through Netlify CI/CD.

Proposed solution

Add bail: true to the webpack configuration e.g. here:

netlify-lambda/lib/build.js

Line 111 in 7ab1220

devtool: false

This way, webpack returns a non-zero exit code when it has an error, and the deployment will fail.

This is what I have done myself via the custom webpack config option, but I think it would be a pretty sensible default to have! 🙂

[swyxio]

want to pr? :) great point.

[omonk]

@sw-yx just opened a PR here: #153

@ericselin, sorry I hope you don't mind. I came across this today and thought it would be very helpful to get this in.

[swyxio]

released v1.4.8