Skip to content

chore: remove manual required redirects from demo toml and add CLI requirements to readme #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 4, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,12 @@ in our docs.

## CLI Usage

### Requirements

To use the Essential Angular Universal plugin while building and deploying with the CLI, you need to have `netlify-cli v5.4.13` installed (or a later version).

Please also make sure to use `ntl deploy --build --prod` (rather than `ntl build`).

### Plugin Side Effects

When this plugin is run as part of the build process using the Netlify CLI, direct changes will be made to your project source:
Expand Down Expand Up @@ -91,4 +97,4 @@ for details.
## License

This project is licensed under the MIT License - see the
[LICENSE.md](LICENSE.md) file for details
[LICENSE.md](LICENSE.md) file for details
7 changes: 0 additions & 7 deletions netlify.toml
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,5 @@ functions = "demo/netlify/functions"
publish = "demo/dist/angular-bfdx/browser"
base="."

# TO-DO: remove after cli redirect fix is out https://github.com/netlify/cli/pull/2920
# any additional redirects for the site should come *before* this one
[[redirects]]
from = "/*"
to = "/.netlify/functions/angular-builder"
status = 200

[[plugins]]
package="."