chore: bump angular@19 from rc to stable #227
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for plugin-angular-universal-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
github-actions
bot
added
the
type: chore
pieh
force-pushed
the
chore/bump-angular-19-to-stable
branch
from
fbd881f to
27c79b6
Compare
…ndencies are updated
pieh
commented
Nov 19, 2024
Comment on lines
+7
to
18
| const excludedPathsWithMaskedHashes = config.excludedPath.map((path) => path.replace(/-[A-Z\d]{8}\./, '-HASHHASH.')) | ||
|
|
||
| assert.deepEqual(excludedPathsWithMaskedHashes, [ | ||
| '/.netlify/*', | ||
| '/favicon.ico', | ||
| '/heroes/index.html', | ||
| '/index.csr.html', | ||
| '/main-KVCR6MBP.js', | ||
| '/polyfills-FFHMD2TL.js', | ||
| '/styles-5INURTSO.css', | ||
| '/main-HASHHASH.js', | ||
| '/polyfills-HASHHASH.js', | ||
| '/styles-HASHHASH.css', | ||
| '/heroes', | ||
| ]) |
There was a problem hiding this comment.
updating this assertion is really annoying so I mask actual hashes with HASHHASH (matching hash length) - we don't necesairly care about concrete hashes - just that we exclude prerendered content from edge function paths
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to check if #148 was false negative which it is.
Ideally, we don't merge this PR and instead adjust Renovate until it's configured correctly so we could actually rely on Renovate for Angular packages bumps. We should still get the test assertion adjustment from here (but this could be committed to renovate PR once it bumps the packages correctly)