Skip to content

chore: create Issue when Angular bump fails #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

serhalp
Copy link
Member

@serhalp serhalp commented May 28, 2024

Configure Renovate to create PRs bumping Angular packages in test fixtures, and add a CI workflow to automatically create an Issue when one of these PRs fails. Separately, we'll configure an integration from GitHub Issues to our triage inbox.

This allows us to find out proactively when new or upcoming releases may cause regressions, before users are affected.

See netlify/remix-compute#355 and netlify/remix-compute#365.

Configure Renovate to create PRs bumping Angular packages in test fixtures, and add
a CI workflow to automatically create an Issue when one of these PRs fails.
Separately, we'll configure an integration from GitHub Issues to our triage inbox.
This allows us to find out proactively when new or upcoming releases may
cause regressions, before users are affected.

See netlify/remix-compute#355 and
netlify/remix-compute#365.
@serhalp serhalp added the type: chore work needed to keep the product and development running smoothly label May 28, 2024
Copy link

netlify bot commented May 28, 2024

Deploy Preview for plugin-angular-universal-demo ready!

Name Link
🔨 Latest commit f23bfaf
🔍 Latest deploy log https://app.netlify.com/sites/plugin-angular-universal-demo/deploys/665614f157a5fe000859c936
😎 Deploy Preview https://deploy-preview-121--plugin-angular-universal-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Comment on lines -9 to -15
packageNames: [
// Those cannot be upgraded to requiring ES modules
'strip-ansi',
],
major: {
enabled: false,
},
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whatever this was, it's already in our shared config

Comment on lines -5 to -6
dependencyDashboard: true,
automerge: true,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are already set upstream

@serhalp serhalp marked this pull request as ready for review May 28, 2024 17:39
@serhalp serhalp requested a review from a team as a code owner May 28, 2024 17:39
Copy link
Contributor

@mrstork mrstork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@serhalp serhalp merged commit 7ddc7bc into main May 29, 2024
18 checks passed
@serhalp serhalp deleted the serhalp/fra-525-notify-first-responder-when-new-framework-releases-cause branch May 29, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: chore work needed to keep the product and development running smoothly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants