Skip to content

docs(fundamentals): improve factory provider example code snippet #3083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

micalevisk
Copy link
Member

@micalevisk micalevisk commented Aug 31, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Docs
  • Other... Please describe:

What is the current behavior?

at our Discord a person asked about the OptionsProvider as they thought that this provider is built-in one

What is the new behavior?

a minor change that should help on clarifying that the class-based provider is just an example

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@kamilmysliwiec kamilmysliwiec merged commit 23f596d into nestjs:master Sep 17, 2024
4 checks passed
@kamilmysliwiec
Copy link
Member

LGTM

@micalevisk micalevisk deleted the patch-1 branch September 17, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants