Skip to content

Handle testkit sending null access mode #912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 12, 2023
Merged

Handle testkit sending null access mode #912

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a46b21b
Add code to handle testkit sending null access mode
thelonelyvulpes Apr 6, 2023
1731d06
Update testkitbackend/_async/requests.py
thelonelyvulpes Apr 6, 2023
b8f3f64
Merge branch '5.0' into testkit/expect-null-accessmode
thelonelyvulpes Apr 11, 2023
4eb4d52
Merge branch '5.0' into testkit/expect-null-accessmode
robsdedude Apr 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions testkitbackend/_async/requests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -536,18 +536,18 @@ def __init__(self, session):

async def NewSession(backend, data):
driver = backend.drivers[data["driverId"]]
access_mode = data["accessMode"]
expected_warnings = []
if access_mode == "r":
access_mode = neo4j.READ_ACCESS
elif access_mode == "w":
access_mode = neo4j.WRITE_ACCESS
else:
raise ValueError("Unknown access mode:" + access_mode)
config = {
"default_access_mode": access_mode,
"database": data["database"],
}
access_mode = data["accessMode"]
if access_mode is not None:
if access_mode == "r":
config["default_access_mode"] = neo4j.READ_ACCESS
elif access_mode == "w":
config["default_access_mode"] = neo4j.WRITE_ACCESS
else:
raise ValueError("Unknown access mode:" + access_mode)
if data.get("bookmarks") is not None:
config["bookmarks"] = neo4j.Bookmarks.from_raw_values(
data["bookmarks"]
Expand Down
16 changes: 8 additions & 8 deletions testkitbackend/_sync/requests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -536,18 +536,18 @@ def __init__(self, session):

def NewSession(backend, data):
driver = backend.drivers[data["driverId"]]
access_mode = data["accessMode"]
expected_warnings = []
if access_mode == "r":
access_mode = neo4j.READ_ACCESS
elif access_mode == "w":
access_mode = neo4j.WRITE_ACCESS
else:
raise ValueError("Unknown access mode:" + access_mode)
config = {
"default_access_mode": access_mode,
"database": data["database"],
}
access_mode = data["accessMode"]
if access_mode is not None:
if access_mode == "r":
config["default_access_mode"] = neo4j.READ_ACCESS
elif access_mode == "w":
config["default_access_mode"] = neo4j.WRITE_ACCESS
else:
raise ValueError("Unknown access mode:" + access_mode)
if data.get("bookmarks") is not None:
config["bookmarks"] = neo4j.Bookmarks.from_raw_values(
data["bookmarks"]
Expand Down