Fix neo4j.time
#683
Merged
Fix neo4j.time
#683
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DateTime objects with fixed negative UTC offset were incorrectly serialized and sent to the database. Similar issue to neo4j#616
Merged
robsdedude
force-pushed
the
fix-datetime-offset-serialization
branch
from
c98ec38 to
bd40cb1
Compare
robsdedude
force-pushed
the
fix-datetime-offset-serialization
branch
from
bd40cb1 to
4725ce1
Compare
Not all implementations of timezones play nicely with custom datetime implementations. In such cases, we need to fall back to native datetimes.
AndyHeap-NeoTech
approved these changes
Mar 31, 2022
robsdedude
added a commit
that referenced
this pull request
Mar 31, 2022
…tion-4.4 [4.4] Fix `neo4j.time` Backport of #683
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DateTimeobjects with fixed negative UTC offset were incorrectlyserialized before sent to the database.