Skip to content

[4.4] Catch up with TestKit's temporary feature flags #637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 5, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 18 additions & 13 deletions testkitbackend/requests.py
Original file line number Diff line number Diff line change
Expand Up @@ -75,22 +75,27 @@ def NewDriver(backend, data):
**auth_token.get("parameters", {})
)
auth_token.mark_item_as_read("parameters", recursive=True)
resolver = None
kwargs = {}
if data["resolverRegistered"] or data["domainNameResolverRegistered"]:
resolver = resolution_func(backend, data["resolverRegistered"],
data["domainNameResolverRegistered"])
connection_timeout = data.get("connectionTimeoutMs")
if connection_timeout is not None:
connection_timeout /= 1000
max_transaction_retry_time = data.get("maxTxRetryTimeMs")
if max_transaction_retry_time is not None:
max_transaction_retry_time /= 1000
kwargs["resolver"] = resolution_func(
backend, data["resolverRegistered"],
data["domainNameResolverRegistered"]
)
if data.get("connectionTimeoutMs"):
kwargs["connection_timeout"] = data["connectionTimeoutMs"] / 1000
if data.get("maxTxRetryTimeMs"):
kwargs["max_transaction_retry_time"] = data["maxTxRetryTimeMs"] / 1000
if data.get("connectionAcquisitionTimeoutMs"):
kwargs["connection_acquisition_timeout"] = \
data["connectionAcquisitionTimeoutMs"] / 1000
if data.get("maxConnectionPoolSize"):
kwargs["max_connection_pool_size"] = data["maxConnectionPoolSize"]
if data.get("fetchSize"):
kwargs["fetch_size"] = data["fetchSize"]

data.mark_item_as_read("domainNameResolverRegistered")
driver = neo4j.GraphDatabase.driver(
data["uri"], auth=auth, user_agent=data["userAgent"],
resolver=resolver, connection_timeout=connection_timeout,
fetch_size=data.get("fetchSize"),
max_transaction_retry_time=max_transaction_retry_time,
data["uri"], auth=auth, user_agent=data["userAgent"], **kwargs
)
key = backend.next_key()
backend.drivers[key] = driver
Expand Down
7 changes: 6 additions & 1 deletion testkitbackend/test_config.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
"Driver rejects empty queries before sending it to the server"
},
"features": {
"Feature:API:Liveness.Check": false,
"Feature:API:Result.List": true,
"Feature:API:Result.Peek": true,
"Feature:API:Result.Single": "Does not raise error when not exactly one record is available. To be fixed in 5.0.",
Expand Down Expand Up @@ -53,8 +54,12 @@
"Temporary:CypherPathAndRelationship": true,
"Temporary:DriverFetchSize": true,
"Temporary:DriverMaxTxRetryTime": true,
"Temporary:FastFailingDiscovery": true,
"Temporary:FullSummary": true,
"Temporary:ResultKeys": true,
"Temporary:TransactionClose": true
"Temporary:TransactionClose": true,
"Temporary:DriverMaxConnectionPoolSize": true,
"Temporary:ConnectionAcquisitionTimeout": true,
"Temporary:GetConnectionPoolMetrics": true
}
}