Skip to content

Testkit: send server info with summary #536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions testkitbackend/requests.py
Original file line number Diff line number Diff line change
Expand Up @@ -289,8 +289,14 @@ def ResultNext(backend, data):

def ResultConsume(backend, data):
result = backend.results[data["resultId"]]
result.consume()
backend.send_response("Summary", {})
summary = result.consume()
backend.send_response("Summary", {
"serverInfo": {
"protocolVersion":
".".join(map(str, summary.server.protocol_version)),
"agent": summary.server.agent
}
})


def RetryablePositive(backend, data):
Expand Down
2 changes: 0 additions & 2 deletions testkitbackend/skipped_tests.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
{
"stub.retry.TestRetryClustering.test_retry_ForbiddenOnReadOnlyDatabase_ChangingWriter":
"Closes connection to router after ROUTE",
"stub.routing.Routing.test_should_use_resolver_during_rediscovery_when_existing_routers_fail":
"DNS resolver not implemented",
"stub.routing.RoutingV3.test_should_use_resolver_during_rediscovery_when_existing_routers_fail":
Expand Down