Try all routers before giving up #529
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robsdedude
commented
Apr 9, 2021
Comment on lines
+758
to
+761
| new_routing_table = self.fetch_routing_table( | ||
| address=router, timeout=self.pool_config.connection_timeout, | ||
| database=database, bookmarks=bookmarks | ||
| ) |
There was a problem hiding this comment.
Make this method always return None instead of raising an exception if anything goes wrong.
| @@ -786,8 +789,12 @@ def update_routing_table(self, *, database, bookmarks): | |||
| ): | |||
| # Why is only the first initial routing address used? | |||
There was a problem hiding this comment.
pop initial router if in list and remove list comprehension further down.
|
Closed in favor of #532 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When attempting to fetch a routing table, the driver shouldn't give up if the first attempt fails but other routers are known.
Remark: we could still do better, but this would require a huge rewrite and might introduce breaking changes.
If a custom resolver function return multiple addresses, the driver will only attempt to fetch a RT from the first server that yields a successful handshake. If that server fails to provide a valid RT for whatever reason, the driver will move on to the next known router. The other addresses returned by the custom resolver function will be ignored.