Proper initialization of system CAs on Windows #475
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should use SSLContext.load_default_certs to load system CAs properly on all platforms including Windows. SSLContext.set_default_verify_paths worked fine on Linux based OSes. load_default_certs is new in Python 3.4.
bigmontz
reviewed
Nov 13, 2020
| @@ -261,7 +261,10 @@ def get_ssl_context(self): | |||
| ssl_context.check_hostname = False | |||
| ssl_context.verify_mode = ssl.CERT_NONE # https://docs.python.org/3.5/library/ssl.html#ssl.CERT_NONE | |||
|
|
|||
| ssl_context.set_default_verify_paths() # https://docs.python.org/3.5/library/ssl.html#ssl.SSLContext.set_default_verify_paths | |||
| # Must be load_default_certs, not set_default_verify_paths to work | |||
| # on Windows with system CAs. | |||
There was a problem hiding this comment.
I think it worths mention the docs (https://docs.python.org/3.5/library/ssl.html#ssl.SSLContext.load_default_certs)
There was a problem hiding this comment.
Hmm, I was a bit annoyed over those references all over the code ;-) I mean finding info on standard python library functions isn't that hard to google
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should use SSLContext.load_default_certs to load system CAs properly on
all platforms including Windows. SSLContext.set_default_verify_paths
worked fine on Linux based OSes. load_default_certs is new in Python
3.4.