1.0 session pool #29
Merged
1.0 session pool #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
technige
force-pushed
the
1.0-session-pool
branch
from
3d18149 to
b5f169b
Compare
| @@ -341,6 +355,11 @@ def __enter__(self): | |||
| def __exit__(self, exc_type, exc_value, traceback): | |||
| self.close() | |||
|
|
|||
| def reset(self): | |||
There was a problem hiding this comment.
Should reset really be a user-facing feature? I'd argue we should encourage users of the Session API to simply close sessions if they are unclear about their state, unless there's a good use case that warrants doing this instead?
|
This is brilliant, super happy to see this come together. I'd love a test that ensures the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.