Skip to content

Skip timeout: connection acquisition timeout includes router handshake #951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 22, 2022

Conversation

robsdedude
Copy link
Member

Required for neo4j-drivers/testkit#474.

See internal ADR for details on the agreed upon approach.

@robsdedude robsdedude requested a review from bigmontz June 21, 2022 15:25
@robsdedude
Copy link
Member Author

robsdedude commented Jun 22, 2022

Can be merged on red as the failure comes from the nightly 5.0-dev cluster having changed how it wants to be configured. It's clearly unrelated to this change.

Copy link
Contributor

@bigmontz bigmontz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐙

Copy link
Contributor

@bigmontz bigmontz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦑

@robsdedude robsdedude merged commit 1ee7abe into neo4j:5.0 Jun 22, 2022
bigmontz pushed a commit to bigmontz/neo4j-javascript-driver that referenced this pull request Jun 22, 2022
@robsdedude robsdedude deleted the skip-timeout-test-5.0 branch June 22, 2022 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants