Skip to content

Decouple Packstream Serialization/De-serialization from Bolt structure hydration #942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

bigmontz
Copy link
Contributor

@bigmontz bigmontz commented Jun 7, 2022

The current implementation of the packstream packer and unpacker also includes the creation of the bolt structures. This implementation join twos different concepts in the same object and this doesn't allow the flexibility needed for working with different structure for the same object in the same bolt version, for instance.

Decoupling this two layer allows the driver supports the new utc feature in a more suitable way.

@bigmontz bigmontz force-pushed the 5.0-decoupling-desserialization-and-hydration branch from 4b029dd to 9e8fd1a Compare June 9, 2022 08:24
@bigmontz bigmontz marked this pull request as ready for review June 9, 2022 14:32
bigmontz added 18 commits June 14, 2022 17:06
… hydration

The current implementation of the packstream packer and unpacker also includes the creation of the bolt structures. This implementation join twos different concepts in the same object and this doesn't allow the flexibility needed for working with different structure for the same object in the same bolt version, for instance.

Decoupling this two layer allows the driver supports the new `utc` feature in a more suitable way.
@bigmontz bigmontz force-pushed the 5.0-decoupling-desserialization-and-hydration branch from 331103e to 161d03f Compare June 14, 2022 15:38
@bigmontz bigmontz merged commit e221878 into neo4j:5.0 Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant