Skip to content

Remove deprecated ResultSummary.version #867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 8, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions packages/core/src/result-summary.ts
Original file line number Diff line number Diff line change
Expand Up @@ -459,7 +459,6 @@ class Notification {
*/
class ServerInfo {
address?: string
version?: string
protocolVersion?: number
agent?: string

Expand All @@ -478,17 +477,6 @@ class ServerInfo {
* @public
*/
this.address = serverMeta.address
/**
* The server version string.
*
* See {@link ServerInfo#protocolVersion} and {@link ServerInfo#agent}
* @type {string}
* @deprecated in 4.3, please use ServerInfo#agent, ServerInfo#protocolVersion, or call the <i>dbms.components</i> procedure instead.
* <b>Method might be removed in the next major release.</b>
* @public
*/
this.version = serverMeta.version

/**
* The server user agent string
Expand Down
2 changes: 0 additions & 2 deletions packages/core/test/result-summary.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ describe('ServerInfo', () => {
4.3,
{
address: '192.168.0.1',
version: 'neo4j',
protocolVersion: 4.3,
agent: 'neo4j'
}
Expand All @@ -36,7 +35,6 @@ describe('ServerInfo', () => {
undefined,
{
address: '192.168.0.1',
version: 'neo4j',
protocolVersion: undefined,
agent: 'neo4j'
}
Expand Down
2 changes: 1 addition & 1 deletion packages/neo4j-driver/test/session.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ describe('#integration session', () => {
const sum = result.summary
expect(sum.server).toBeDefined()
expect(sum.server.address).toEqual(`${sharedNeo4j.hostname}:7687`)
expect(sum.server.version).toBeDefined()
expect(sum.server.version).toBeUndefined()
done()
})
}, 70000)
Expand Down
5 changes: 2 additions & 3 deletions packages/neo4j-driver/test/transaction.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -311,7 +311,7 @@ describe('#integration transaction', () => {
const sum = result.summary
expect(sum.server).toBeDefined()
expect(sum.server.address).toEqual(`${sharedNeo4j.hostname}:7687`)
expect(sum.server.version).toBeDefined()
expect(sum.server.version).toBeUndefined()
tx.commit().then(done)
})
.catch(console.log)
Expand All @@ -331,8 +331,7 @@ describe('#integration transaction', () => {

expect(server).toBeDefined()
expect(server.address).toEqual(`${sharedNeo4j.hostname}:7687`)
expect(server.version).toBeDefined()

expect(server.version).toBeUndefined()
done()
}
})
Expand Down
1 change: 0 additions & 1 deletion packages/neo4j-driver/test/types/driver.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,6 @@ session1
const close: Promise<void> = driver.close()

driver.verifyConnectivity().then((serverInfo: ServerInfo) => {
console.log(serverInfo.version)
console.log(serverInfo.address)
})

Expand Down
1 change: 0 additions & 1 deletion packages/neo4j-driver/test/types/result-summary.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,6 @@ const column: number = position2.column

const server: ServerInfo = sum1.server
const address: string | undefined = server.address
const version: string | undefined = server.version

const resultConsumedAfter1: Integer = sum1.resultConsumedAfter
const resultAvailableAfter1: Integer = sum1.resultAvailableAfter
Expand Down