testkit: Implements ForcedRoutingTableUpdate #796
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It also fix the GetRoutingTable request handler adding a default value where there is no routing table registered.
robsdedude
reviewed
Oct 22, 2021
robsdedude
approved these changes
Oct 22, 2021
| const provider = driver._getOrCreateConnectionProvider() | ||
|
|
||
| if (provider._freshRoutingTable) { | ||
| // Removing database from the routing table registry |
There was a problem hiding this comment.
I'll take the PR as is. But I'll suggest to extend that comment with a few words explaining why you decided to delete the RT and go through _freshRoutingTable instead of just calling _refreshRoutingTable which might seem like the better solution (but isn't as you commented).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It also fix the GetRoutingTable request handler adding a default value where there is no routing table registered.