-
Notifications
You must be signed in to change notification settings - Fork 151
RxJS 7 #774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RxJS 7 #774
Conversation
Hi @CarsonF, Thanks for contributing and sorry for the delayed response. This PR is a potential breaking change due to the use of RxJS 7, https://rxjs.dev/deprecations/breaking-changes. We will defer this change until the next major release (5.0) when we can merge the PR. |
Hi @CarsonF, For your PR be able to be reviewed, you need to read and sign Neo4j's CLA (https://neo4j.com/developer/cla/). Thanks. |
Hey @bigmontz, I did send the CLA email back when I opened the PR. Should I send again? |
Hey @CarsonF, thanks for the response. I've found your agreement. Could you please rebase and change the branch target to 5.0? |
Since rebase on top of 5.0 was not done in time for the 5.0 window, the feature was re-implemented in #927. Sorry for the inconvenience, but this PR will be closed. Thanks for contributing. |
throwError
usage to pass error creatorflatMap
import withmergeMap
concat
import withconcatWith
toPromise
withlastValueFrom
Notification
instances with plain objectspublishReplay
+refCount
withshareReplay
RxTransaction
&RxSession
usingfrom
&defer
I didn't update the lock file because I have a newer version of npm and updated the entire file. Hopefully a maintainer can commit this.