Skip to content

Fix issues which are blocking the build pipeline #769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 3, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions core/src/record.ts
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ class Record<
*/
forEach(visitor: Visitor<Entries, Key>): void {
for (const [key, value] of this.entries()) {
visitor(value as any, key as any, this)
visitor(value, key as Key, this)
}
}

Expand All @@ -128,7 +128,7 @@ class Record<
const resultArray = []

for (const [key, value] of this.entries()) {
resultArray.push(visitor(value as any, key as any, this))
resultArray.push(visitor(value, key as Key, this))
}

return resultArray
Expand Down Expand Up @@ -180,7 +180,7 @@ class Record<
const obj: Entries = {} as Entries

for (const [key, value] of this.entries()) {
obj[key as any] = value
obj[key as Key] = value
}

return obj
Expand Down
2 changes: 1 addition & 1 deletion core/test/result.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -407,7 +407,7 @@ describe('Result', () => {
it('should call finally on error', done => {
streamObserverMock.onError(expectedError)

result.finally(done)
result.catch(() => {}).finally(done)
})

describe.each([
Expand Down