Skip to content

Fix utf8 decoding across combined buffers #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 11, 2016
Merged

Fix utf8 decoding across combined buffers #72

merged 1 commit into from
May 11, 2016

Conversation

pontusmelke
Copy link
Contributor

There were still some issues remaining when doing decoding across combined buffers.

  • Position pointer should be properly updated after calling decode on a combined buffer
  • Respect the current position in the combined buffer when decoding
  • Position pointer should never exceed the length of the buffer

@pontusmelke pontusmelke force-pushed the 1.0-mangled-records branch from f804b40 to 9d1b43d Compare May 11, 2016 09:28
@pontusmelke pontusmelke merged commit 9d0db33 into neo4j:1.0 May 11, 2016
@pontusmelke pontusmelke deleted the 1.0-mangled-records branch May 11, 2016 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pontusmelke