Refactoring the stream observer to use a state machine #515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 18, 2019 17:16
to describe the inner state changes. This stream observer is used as reactive run and pull handler, async run and pull handler, as well as other message handlers. For reactive run and pull handler, the start state is `READY` state where a run message is sent and we will auto write a pull message once the run message reply is received. For async run and pull handler, the start state is `READY_STREAMING` where a run and a pull message are sent and we will auto write a pull message once apull message reply is received with has_more flag. For other single message handlers, the start state is `STREAMING` where we will wait for a success reply and save all meta received.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to describe the inner state changes.
This stream observer is used as reactive run and pull handler, async run and pull handler, as well as other message handlers.
For reactive run and pull handler, the start state is
READYstate where a run message is sent and we will auto write a pull message once the run message reply is received.For async run and pull handler, the start state is
READY_STREAMINGwhere a run and a pull message are sent and we will auto write a pull message once a pull message reply is received with has_more flag.For other single message handlers, the start state is
STREAMINGwhere we will wait for a success reply and save all meta received.