Add supportsMultiDb function #491
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ali-ince
force-pushed
the
4.0-supports-multidb
branch
from
7494aa4 to
1d392ca
Compare
|
Thanks @ali-ince! |
ali-ince
force-pushed
the
4.0-supports-multidb
branch
from
1d392ca to
f7913f1
Compare
zhenlineo
approved these changes
Oct 2, 2019
|
@zhenlineo we wanted it to happen even without authentication (due to the fact that on initial login the password could be reported as expired and nothing other than change password functionality is allowed) so picked the handshake path. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
supportsMultiDbmethod on Driver, that when called negotiates a protocol for the remote database (or one of the seed routers) and returns a boolean Promise telling whether it supports multi database features based on the bolt protocol version only.Based on #490.