Multi-database routing #471
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zhenlineo I'm merging this PR. Please feel free to add your comments and I'll address them in a seperate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings multi-database routing support to the javascript driver. Besides this core feature, it includes a couple of small other changes as well.
dbparameter specified during session construction (for selecting the target database) is updated asdatabaseto make it aligned with other drivers.driver.onErrorcallback completely.unitandintegrationand are now possible to selectively execute them usinggulp test-nodejs-unitorgulp test-nodejs-integration. Or it is possible to directly use filter argument tojasmineexecutable to filter desired tests to be run (i.e.jasmine --filter="#unit*").