Skip to content

Remove deprecated API #447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 8, 2019
Merged

Remove deprecated API #447

merged 2 commits into from
Apr 8, 2019

Conversation

ali-ince
Copy link
Contributor

@ali-ince ali-ince commented Apr 4, 2019

This PR removes previously deprecated API. These are;

  1. TRUST_ON_FIRST_USE and TRUST_SIGNED_CERTIFICATES trust strategies are removed along with knownHosts configuration option that is related with TRUST_ON_FIRST_USE.
  2. loadBalancingStrategy configuration option is removed and least_connected is the only option going forward.
  3. connectionPoolSize configuration option is removed and maxConnectionPoolSize is the only option that has affect on the connection pool sizing.
  4. Driver.onCompleted event property is now removed and replaced by Driver.verifyConnectivity which returns a Promise.

@ali-ince ali-ince requested review from oskarhane and zhenlineo April 4, 2019 15:09
@ali-ince
Copy link
Contributor Author

ali-ince commented Apr 4, 2019

@oskarhane would you please take a look this PR, especially how we've replaced Driver.onCompleted?

Copy link
Member

@oskarhane oskarhane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @ali-ince

@ali-ince ali-ince merged commit cb87a3e into neo4j:2.0 Apr 8, 2019
@ali-ince ali-ince deleted the 2.0-api-changes branch July 3, 2019 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants