Fix flaky http driver test #359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It executes same query that returns paths using bolt and http. Results are then compared and expected to be the same. Previously used query was not entirely deterministic and could return different results for subsequent executions. This commit fixes the problem by making var-length queries use fixed start node. Also added logging of query when expectation fails.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It executes same query that returns paths using bolt and http. Results are then compared and expected to be the same. Previously used query was not entirely deterministic and could return different results for subsequent executions.
This commit fixes the problem by making var-length queries use fixed start node. Also added logging of query when expectation fails.