Added ability to enforce max connection lifetime #282
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Driver keeps idle network connections in a connection pool. These connections can get invalidated while resting idle in the pool. They can be killed by network equipment like load balancer, proxy or firewall. It is also safer to refresh connections once in a while so that database can renew corresponding resources. This commit adds `maxConnectionLifetime` setting and makes driver close too old connections. Checking and closing happens during connection acquisition. Also removed manual `Date.now()` mocking in favour of existing library - Lolex.
lutovich
force-pushed
the
1.5-maxConnectionLifetime
branch
from
be86f3a to
2e9415d
Compare
praveenag
approved these changes
Aug 14, 2017
| @@ -19,18 +19,22 @@ | |||
|
|
|||
| import neo4j from '../../src/v1'; | |||
| import sharedNeo4j from '../internal/shared-neo4j'; | |||
| import FakeConnection from '../internal/fake-connection'; | |||
| import lolex from 'lolex'; | |||
There was a problem hiding this comment.
This is a good addition 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Driver keeps idle network connections in a connection pool. These connections can get invalidated while resting idle in the pool. They can be killed by network equipment like load balancer, proxy or firewall. It is also safer to refresh connections once in a while so that database can renew corresponding resources.
This PR adds
maxConnectionLifetimesetting and makes driver close too old connections. Checking and closing happens during connection acquisition.Also removed manual
Date.now()mocking in favour of existing library - Lolex.