Extract load balancing logic in a separate class #265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously load balancing logic for read and write servers was coupled with storage of server addresses in `RoundRobinArray` class. Such approach was problematic because it made hard to use different load balancing strategy. This commit pulls load balancing in a separate class and removes `RoundRobinArray`. Instead addresses are stored in simple arrays and load balancing logic is applied to those arrays. Such approach makes it easy to plug a different load balancing strategy.
Previously `RoundRobinArray`s in a routing table were recreated on every rediscovery. This caused round robin index to be reset to zero. It is no longer true because `RoundRobinLoadBalancingStrategy` does not reset indexes.
praveenag
suggested changes
Jul 11, 2017
| } | ||
| } | ||
|
|
||
| export class RoundRobinLoadBalancingStrategy extends LoadBalancingStrategy { |
There was a problem hiding this comment.
Could we maybe extract this to a file of it's own. It has it's own purpose and it makes sense in imports to import it as
import {RoundRobinLoadBalancingStrategy} from './round-robin-load-balancing-strategy';
praveenag
approved these changes
Jul 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously load balancing logic for read and write servers was coupled with storage of server addresses in
RoundRobinArrayclass. Such approach was problematic because it made hard to use different load balancing strategy.This PR pulls load balancing in a separate class and removes
RoundRobinArray. Instead addresses are stored in simple arrays and load balancing logic is applied to those arrays. Such approach makes it easy to plug a different load balancing strategy.