Introduce explicity resource management to Driver and Session objects #1154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a TC39 [proposal](https://github.com/tc39/proposal-explicit-resource-management) which is already implemented in Typescript 5.2, core-js, babel and other pollifyl tools. This feature enables the user create the driver or a session with the `await using` keywords and then do not have to close the resource afterwards, since this resources will be closed after leaving the block which were created at. For example: ```typescript await using driver = neo4j.driver(uri, authToken) await using session = driver.session() await session.executeRead(tx => "RETURN 1") ``` Since Deno is more strict with typescript, small fixes had to be done in the driver. * Add a value to Result[Symbol.toStringTag]. * Fix Integer.shiftRight function to add propert integer convertion it. A package.json file was added to the `neo4j-driver-deno` folder for making easier to integrate the test runners to the environments.
ConorNeo
approved these changes
Oct 26, 2023
bigmontz
deleted the
5.x-add-explicity-resource-management-to-session-and-driver
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a TC39 proposal which is already implemented in Typescript 5.2, core-js, babel and other polyfill tools.
This feature enables the user create the driver or a session with the
await usingkeywords and then do not have to close the resource afterwards, since this resources will be closed after leaving the block which were created at.For example:
Since Deno is more strict with typescript, small fixes had to be done in the driver.
A package.json file was added to the
neo4j-driver-denofolder for making easier to integrate the test runners to the environments.