Fix RxResult performance issue in Browser #1023
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`setImmediate` was slowing down the result consumption since it postpone the execution to the next cycle. Since the cycle in Browser is longer, the issue was more perceptive there. The remove of `setImmediate` doesn't cause any issue with the back-pressure machanics.
AndyHeap-NeoTech
approved these changes
Nov 25, 2022
fbiville
approved these changes
Nov 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setImmediatewas slowing down the result consumption since it postpone the execution to the next cycle. Since the cycle in Browser is longer, the issue was more perceptive there.The remove of
setImmediatedoesn't cause any issue with the back-pressure mechanics.