Assign attrs to created script element #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eerikson
commented
Apr 5, 2018
| var doc = document | ||
| var tag = 'script' | ||
| var firstScript | ||
| var el | ||
| el = doc.createElement(tag) | ||
| firstScript = doc.getElementsByTagName(tag)[0] | ||
| if (attrs) { |
There was a problem hiding this comment.
Placement is important here—we want to control & possibly overwrite async, src, onload, etc
There was a problem hiding this comment.
could you make attrs = {} by default and then just simply (with no conditional):
Object.assign(el, attrs);
There was a problem hiding this comment.
Please keep in mind that we're not using babel here, so let's keep compatibility to IE11.
There was a problem hiding this comment.
yeah im trying to keep it old school in this PR.
eerikson
commented
Apr 5, 2018
| var doc = document | ||
| var tag = 'script' | ||
| var firstScript | ||
| var el | ||
| return new Promise(function (resolve, reject) { | ||
| el = doc.createElement(tag) | ||
| firstScript = doc.getElementsByTagName(tag)[0] | ||
| if (attrs) { |
eerikson
force-pushed
the
AllowArbitraryPropsOnScriptEl
branch
from
f4ba9fb to
2556a05
Compare
mmase
approved these changes
Apr 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need this feature to allow optional
crossOriginon behance. However, might be nice for any user of this package to define arbitrary properties on<script />.