Combining coverage across platforms on coverage 7

[gaborbernat]

This worked with coverage<7, but seems broke with 7.0. Any ideas about what's the issue here? The changelog seems unhelpful.

See: https://github.com/platformdirs/platformdirs/actions/runs/3789103896/jobs/6442564756

The main problem seems to be that paths in the report are absolute and not relative so we can map it back to existing files, see https://github.com/platformdirs/platformdirs/blob/main/pyproject.toml#L57

[nedbat]

It stopped working because you moved the coverage settings from setup.cfg to pyproject.toml. Coverage looks in .coveragerc, setup.cfg, tox.ini, pyproject.toml in that order. It's finding the tox.ini file, and seeing no settings, so using the defaults. I thought it would use the first of those files that had actual coverage settings, so it should read the pyproject.toml. I'm still looking into that.

[gaborbernat]

It stopped working because you moved the coverage settings from setup.cfg to pyproject.toml. Coverage looks in .coveragerc, setup.cfg, tox.ini, pyproject.toml in that order. It's finding the tox.ini file, and seeing no settings, so using the defaults. I thought it would use the first of those files that had actual coverage settings, so it should read the pyproject.toml. I'm still looking into that.

It did not work with setup.cfg neither 😊 but while debugging decided to move it. See https://github.com/platformdirs/platformdirs/actions/runs/3786100702/jobs/6436710769 that fails with setup.cfg too 😊

[nedbat]

I fixed a bug in coverage.py that failed to warn you that you had settings in a .toml file, but no toml library to read them with. This is fixed in 3823cc6. I also made changes in platformdirs: tox-dev/platformdirs#121

[gaborbernat]

Given 3.11 has toml library built-in why do we need the extra?

[nedbat]

You don't need the extra if you run on 3.11, but your combine step is running on 3.10.

[gaborbernat]

Ah good spot, thank you!