Skip to content

Fixed prompts, added required html5 mode prompt and fixed a typo #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 10, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions generator/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ module.exports = (api, options, rootOptions) => {
applicationDescription: api.generator.pkg.description || api.generator.pkg.name,
applicationLicense: api.generator.pkg.license || 'MIT',
applicationId: options.applicationId,
historyMode: options.historyMode || false,
})

// delete the "public" directory
Expand Down
3 changes: 1 addition & 2 deletions index.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,7 @@ module.exports = (api, projectOptions) => {
const vueRule = config.module.rule('vue').test(/\.vue$/)

vueRule.use('vue-loader').tap(options => {
// todo fix typo when pr merged
options.compilerOpitons.compiler = require('nativescript-vue-template-compiler')
options.compilerOptions.compiler = require('nativescript-vue-template-compiler')
options.compilerOptions = options.compilerOpitons
delete options.compilerOpitons;
})
Expand Down
22 changes: 19 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,13 +1,14 @@
{
"name": "vue-cli-plugin-nativescript-vue",
"version": "0.0.1",
"version": "0.0.3",
"description": "A vue cli 3.x plugin for NativeScript-Vue",
"main": "index.js",
"files": [
"index.js",
"lib",
"generator",
"LICENSE"
"LICENSE",
"prompts.js"
],
"scripts": {
"test": "echo \"Error: no test specified\" && exit 1"
Expand All @@ -19,5 +20,20 @@
"devDependencies": {
"nativescript-vue-template-compiler": "^1.3.1",
"rimraf": "^2.6.2"
}
},
"repository": {
"type": "git",
"url": "git+https://github.com/nativescript-vue/vue-cli-plugin-nativescript-vue.git"
},
"keywords": [
"vue",
"cli",
"nativescript",
"web",
"plugin"
],
"bugs": {
"url": "https://github.com/nativescript-vue/vue-cli-plugin-nativescript-vue/issues"
},
"homepage": "https://github.com/nativescript-vue/vue-cli-plugin-nativescript-vue#readme"
}
6 changes: 6 additions & 0 deletions prompts.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,5 +18,11 @@ Example: com.company.app`

return true;
}
},
{
name: 'historyMode',
type: 'confirm',
message: 'Use HTML5 history mode? (Default: hash mode)',
default: false
}
]