Skip to content

Implicitly set an id to the Navigator frame #27

Closed
@rigor789

Description

@rigor789

When creating a Navigator frame, we should implicitly set an id and not use the default one.

The issue is when you have multiple frames, you might run into a situation where both the Navigator and your Frame will try to use the same ID.

In NativeScript-Vue 2.5.0 we removed the frame-id collision handling, as it was causing another set of issues (nativescript-vue/nativescript-vue#532), causing the last created Frame instance with a given id to overwrite the previous one in the Frame lookup table causing unexpected navigation behaviour.

The fix is simple, we can add a new id property with a default value of navigatorFrame for instance, and refactor all calls to $navigateTo and $navigateBack to include this id as a navigation option.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions