-
-
Notifications
You must be signed in to change notification settings - Fork 9
Update nbgv to 3.7.112 #290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Warning Rate limit exceeded@josesimoes has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 15 minutes and 56 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ⛔ Files ignored due to path filters (3)
📒 Files selected for processing (2)
WalkthroughThis pull request updates the Changes
Possibly related PRs
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
source/TestAdapter/packages.lock.json (1)
49-51
: Version update is consistent across target frameworks!The Nerdbank.GitVersioning package has been correctly updated to version 3.7.112 in both target frameworks (.NET Framework 4.8 and .NET 6.0).
Consider aligning version constraints
The version constraint in TestAdapter (
[3.7.112, )
) differs from TestFramework ([3.7.112, 3.7.112]
). Consider using the same version constraint across both projects to prevent potential version mismatches in the future.- "requested": "[3.7.112, )", + "requested": "[3.7.112, 3.7.112]",Also applies to: 193-195
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (2)
source/TestAdapter/nanoFramework.TestAdapter.csproj
is excluded by none and included by nonesource/TestFramework/packages.config
is excluded by none and included by none
📒 Files selected for processing (2)
source/TestAdapter/packages.lock.json
(2 hunks)source/TestFramework/packages.lock.json
(1 hunks)
🔇 Additional comments (1)
source/TestFramework/packages.lock.json (1)
13-15
: Version update looks good!
The Nerdbank.GitVersioning package has been correctly updated to version 3.7.112 with matching requested and resolved versions.
cafe0ee
to
ef55efa
Compare
ef55efa
to
3054ae3
Compare
Description
Motivation and Context
How Has This Been Tested?
Screenshots
Types of changes
Checklist:
Summary by CodeRabbit
Nerdbank.GitVersioning
to enhance stability and performance.